fix: disableAutoSnapshot not working as expected
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackleslie thanks for identifying the issue and making the fix! We'll take a look at this. |
Fix the linting error
Fix linting
|
@skitterm thanks for taking a look! I see that some checks are still failing, is there anything I need to do? |
@jackleslie you're good! I'll take it from here. Some checks require the PR to be from a non-fork branch to pass. I'll change this base branch to my (non-fork) branch, and after merging I'll make another PR from my branch to |
skitterm
approved these changes
May 28, 2024
skitterm
changed the base branch from
main
to
enable-manual-snapshots-without-automatic
skitterm
merged commit accd2fa
into
chromaui:enable-manual-snapshots-without-automatic
4 of 5 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #131
What Changed
From documentation:
I believe currently when
disableAutoSnapshotis set totruewe are not proceeding to theprepareArchivestask, so rather than disabling the automatic snapshot we are disabling all snapshotsHow to test
disableAutoSnapshot: truegloballycy.takeSnapshot()